Add extra offset when scrolling to a section in Documentati… #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mportiz08
reviewed
Sep 22, 2022
| * @param {import('vue-router').Route} to | ||
| * @returns {Number} | ||
| */ | ||
| export default function getExtraScrollOffset(to) { |
Contributor
There was a problem hiding this comment.
Would it make sense to move this to the existing router-utils.js file where we already have utilities related to scrolling (and also offsets for scrolling) as opposed to creating an entirely new scroll-offset.js file?
Contributor
Author
There was a problem hiding this comment.
Thought it might be easier for future 3rd party users to extend this function 🤔
Co-authored-by: Marcus Ortiz <[email protected]>
…thub.com/dobromir-hristov/swift-docc-render into dhristov/r100028167-add-scroll-to-offset
mportiz08
approved these changes
Sep 23, 2022
Contributor
Author
|
@swift-ci test |
dobromir-hristov
deleted the
dhristov/r100028167-add-scroll-to-offset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 100028167
Summary
Adds an extra offset to the scrollTo helper function, only for the documentation page.
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded