Increment render node version for variantOverrides #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dobromir-hristov
approved these changes
Nov 18, 2021
Contributor
|
@swift-ci test |
Increments the patch value of the render node schema to 0.2.0 to account for addition of the top-level `variantOverrides` property.
franklinsch
force-pushed
the
increment-render-json-version
branch
from
757565a to
27e771b
Compare
mportiz08
approved these changes
Nov 18, 2021
Contributor
|
@swift-ci test |
mportiz08
requested changes
Nov 18, 2021
Contributor
mportiz08
left a comment
mportiz08
left a comment
There was a problem hiding this comment.
@franklinsch can you update the tests in tests/unit/utils/schema-version-check.spec.js to accommodate this change? I think some of them are failing now (possibly due to some strings where a version is hardcoded)
Contributor
|
@swift-ci test |
dobromir-hristov
approved these changes
Nov 19, 2021
mportiz08
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: N/A
Summary
Increments the minor value of the render node schema to 0.2.0 to account
for addition of the top-level
variantOverridesproperty introduced in swiftlang/swift-docc#11.Dependencies
This is related to swiftlang/swift-docc#43.
Testing
N/A
Checklist
[ ] Added testsN/Anpm testscript and it succeeded