Fix bug preventing navigation to page after toggling language #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Navigating to a _new page_ in ObjC mode should trigger a new data request * Navigating to a _new page_ in ObjC mode should apply a patch when available
This is not necessarily a problem now but there could be a future service that renders a topic with the same identifier with different URLs, so this Vue component key would be a better alternative in that scenario and should work the same for pages now.
mportiz08
requested review from
dobromir-hristov,
ethan-kusters,
hqhhuang and
marinaaisa
Contributor
Author
|
@swift-ci test |
mportiz08
deleted the
85271020/fix-objc-data-flow-with-variant-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 85271020
Summary
This fixes the following 2 issues with the logic for the new "variant overrides" support:
These scenarios weren't accounted for because the majority of testing done previously was simply done by simulating toggling the language on the same page and didn't include example data for subsequent navigation.
Testing
Steps:
VUE_APP_DEV_SERVER_PROXY=/path/to/unzipped/archiveand runnpm run serveSimpleClasssymbolSimpleClassloads and is showing Objective-C contentChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded