[Tests] Properly link Linux tests #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang#46 is missing this change to the compiler invocation, which allows tests to run on Linux even when `--library-install-path` and `--module-install-path` are not specified.
Contributor
Author
|
Once this is merged, I plan on adding swift-corelibs-xctest to the Swift CI, by submitting a pull request with this change: modocache/swift@b2f2546 |
mike-ferris
pushed a commit
that referenced
this pull request
Feb 15, 2016
[Tests] Properly link Linux tests
Contributor
Author
|
Awesome, thanks @mike-ferris-apple! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 is missing this change to the compiler invocation, which allows tests to run on Linux even when
--library-install-pathand--module-install-pathare not specified.My bad, this should have been included in #46. With this change, the following now works: