Expectation handlers need to be @Sendable. #454 #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Jun 26, 2023
dennisweissmann
approved these changes
Jun 26, 2023
briancroom
approved these changes
Jun 26, 2023
Contributor
Author
|
@swift-ci please test Windows |
Contributor
Author
|
@swift-ci please smoke test Windows |
Contributor
Author
|
|
Contributor
Author
|
@swift-ci please clean test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for example https://developer.apple.com/documentation/xctest/xctnsnotificationexpectation/handler
The handlers for
XCTestExpectationsubclasses need to be@Sendablebecause they can be invoked asynchronously or concurrently.Resolves #454.