CMake: Install shared/import libraries into bin/lib on Windows #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci test |
compnerd
previously requested changes
May 2, 2019
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This will break the non-Windows install unfortunately :-(. Please follow the same thing as Foundation.
Contributor
Author
|
Thanks for point, Foundation really helps. I think I got it now. |
Member
|
Can you please squash the changes into a single commit? |
Member
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I should report to Jira first. CMake Install on Windows copies
XCTest.dlltwice, and skipsXCTest.lib:usr\lib\XCTest.dllusr\lib\swift\windows\XCTest.dllI believe it have to be
usr\bin\XCTest.dllusr\lib\swift\windows\XCTest.lib