Add class-level setUp and tearDown methods on XCTestCase
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var value = 0 | ||
|
|
||
| // CHECK: In class setUp\(\) |
Contributor
There was a problem hiding this comment.
With #94 merged you may now indent the // CHECK:, like so:
func myFunc() {
// CHECK: foo
print("foo")
if (bar) {
// CHECK: baz
print("baz")
}
}I think indenting is more readable, so I'd encourage you to do that! (I had been meaning to start sending out pull requests to indent the checks in the tests, but forgot 😇 )
Contributor
Author
There was a problem hiding this comment.
Ooh right, thanks for the reminder! I'll just change the newly-added lines for now though to keep the diff clean.
Contributor
|
Excellent! 💯 |
briancroom
force-pushed
the
class-setUp-tearDown
branch
from
fe31f89 to
69dc41b
Compare
Contributor
Author
|
Thanks for the feedback @modocache. I pushed some tweaks now. Would someone mind kicking off CI? (I'll also note that this will be the first build since swiftlang/swift#2259 was merged.) Thanks! |
|
@swift-ci please test |
Contributor
Author
|
Success 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
setUpandtearDownclass methods onXCTestCasewhich Apple XCTest has, and we were still missing. These are called by a privateXCTestSuitesubclass which is configured explicitly with the test case class whose tests are in the suite.