Skip to content

[TLS]: Pass a heap-allocated value to pthread_setspecific() #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[TLS]: Pass a heap-allocated value to pthread_setspecific() #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ _dispatch_install_thread_detach_callback(dispatch_function_t cb)
void
_libdispatch_tsd_cleanup(void *ctx)
{
struct dispatch_tsd *tsd = (struct dispatch_tsd*) ctx;
struct dispatch_tsd *tsd = *(struct dispatch_tsd **)ctx;

_tsd_call_cleanup(dispatch_priority_key, NULL);
_tsd_call_cleanup(dispatch_r2k_key, NULL);
Expand Down Expand Up @@ -933,7 +933,15 @@ DISPATCH_NOINLINE
void
libdispatch_tsd_init(void)
{
pthread_setspecific(__dispatch_tsd_key, &__dispatch_tsd);
// pthread_setspecific() requires the value to be heap allocated
// memory as it gets free()'d by the pthread destructor.
struct dispatch_tsd **tsd_ptr = malloc(sizeof(struct dispatch_tsd *));
if (tsd_ptr == NULL) {
perror("malloc");
exit(1);
}
*tsd_ptr = &__dispatch_tsd;
pthread_setspecific(__dispatch_tsd_key, tsd_ptr);
__dispatch_tsd.tid = gettid();
}
#endif
Expand Down