Upgrading to the new integer protocols #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
parkera
reviewed
Apr 17, 2017
|
|
||
| @_transparent | ||
| public mutating func add(_ other: CGFloat) { | ||
| native.add(other.native) |
Contributor
There was a problem hiding this comment.
Is this a source-compatible change?
Contributor
Author
There was a problem hiding this comment.
Technically not, but these methods were there only to implement operators on the protocol, which is no longer required. In any case these missing methods can now be added for source compatibility in the protocol. Thanks for looking at this!
Contributor
Author
There was a problem hiding this comment.
Added the missing methods here: swiftlang/swift@192c112
moiseev
changed the title
Contributor
Author
|
@parkera I've just merged the new integers into master. Is it OK for me to merge this one? |
Contributor
|
This is blocking PR testing on Linux so I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.