Restore use of #include #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change made in swiftlang#663 were overwritten by swiftlang#709. This change restores the switch from `#import` to `#include`. The reason for this change is: Clang's MSVC compatibility does not handle `#import` statements outside of of objc. > #import of type library is an unsupported Microsoft feature
Contributor
|
Under which circumstances would |
Contributor
Author
|
Recently I merged and noticed this conflict. I put up this pull request to restore the original fix, assuming it was still useful. I see now that's not the case, but would like to see it go in to prevent future changes in the conditionals from breaking compilation down the road. |
Contributor
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change made in #663 was overwritten by #709. This change restores the switch from
#importto#include.The reason for this change is: Clang's MSVC compatibility does not handle
#importstatements outside of of objc.