Fix for [SR-3448] Crash in String.replacingOccurrences(of:with:) with… #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… emoji on Linux Foundation.NSMutableString.replaceCharacters assumed that the passed-in NSRange was character-based but it's UTF-16 based. The fix was to use the UTF-16 view and then convert the indexes back to characters.
Contributor
|
Thanks! |
Contributor
|
@swift-ci test and merge |
This was referenced May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… emoji on Linux
Foundation.NSMutableString.replaceCharacters assumed that the passed-in NSRange was character-based but it's UTF-16 based.
The fix was to use the UTF-16 view and then convert the indexes back to characters.
All credit to @allevato for coming up with the fix.
This also resolves [SR-3449].