[Musl] Add missing autolink arguments, fix CFPosixSpawnFileActionsChdir. #5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsChdir. We need a handful more autolink arguments; these were in a previous PR, but seem to have gone missing at some point during the re-core. Additionally, Musl has the `posix_spawn_file_actions_addchdir_np()` function rather than the non-`_np()` version. Fixes swiftlang#5089.
Contributor
Author
|
@swift-ci Please test Linux platform |
Contributor
Author
|
@swift-ci Please test Windows platform |
Contributor
Author
|
Explanation: We need to add the autolink options in order for programs built with the Static SDK to work without having to add extra linker arguments. Also, Musl has the |
shahmishal
approved these changes
Oct 18, 2024
parkera
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a handful more autolink arguments; these were in a previous PR, but seem to have gone missing at some point during the re-core.
Additionally, Musl has the posix_spawn_file_actions_addchdir_np() function rather than the non-_np() version.
rdar://138023731