[6.0] Fix CFTimeZone crashes on Windows #5072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix CFTimeZone crashes on Windows * Fix build failure
|
@swift-ci please test |
itingliu
approved these changes
Aug 16, 2024
compnerd
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a new crash in Swift 6 when calling to
CFTimeZoneAPIs on WindowsScope: Only impacts
CFTimeZoneon WindowsOriginal PR: #5070
Risk: Low to moderate - introduces a nontrivial amount of new C code, however it has been tested locally and the scope is limited
Testing: Testing done via local testing via the SwiftPM build
Reviewer: @compnerd @itingliu