Skip to content

Conversation

@xwu
Copy link
Contributor

@xwu xwu commented Jul 28, 2016

Needs to be committed simultaneously with apple/swift PR implementing SE-0134.

@atrick atrick merged commit d1a3d80 into swiftlang:master Jul 28, 2016
@jrose-apple
Copy link
Contributor

This should use nullTerminatedUTF8, not utf8CString, no?

@xwu
Copy link
Contributor Author

xwu commented Jul 28, 2016

Core team decision was to remove nullTerminatedUTF8 altogether.
On Thu, Jul 28, 2016 at 13:31 Jordan Rose [email protected] wrote:

This should use nullTerminatedUTF8, not utf8CString, no?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#486 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA2gNIouPk2CiWvg26a3oztqplgk15bks5qaPWHgaJpZM4JW0CP
.

@atrick
Copy link
Contributor

atrick commented Jul 28, 2016

@jrose-apple nullTerminatedUTF8 was removed. I always merge the foundation change right before the swift change so the CI passes. But I just found out I'm not authorized to merge anything and couldn't find anyone who could do it.
swiftlang/swift#3816

@xwu xwu deleted the migrate-for-se-0134 branch July 28, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants