Foundation: improve relative path computation for iteration on Windows #4797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially corrects the relative path computation. We no longer fail to create the file system representation if it exceeds `MAX_PATH` due to the switch to `withUnsafeNTPath`. We will still fail to properly create the relative path if the paths are unrelated and if the relative path exceeds `MAX_PATH`. However, this still is an improvement over the status quo.
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially corrects the relative path computation. We no longer fail to create the file system representation if it exceeds
MAX_PATHdue to the switch towithUnsafeNTPath. We will still fail to properly create the relative path if the paths are unrelated and if the relative path exceedsMAX_PATH. However, this still is an improvement over the status quo.