Fix incompatible function pointer type #4699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libxml2 added `const` to `xmlHashScanner` in v2.9.8. Wrap the call in a version check and cast for the non-const case.
Contributor
Author
|
@shahmishal the other option is to update libxml2 on whatever CI jobs are currently failing with this. Not sure if that's an option, so have put this up just in case. |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
compnerd
approved these changes
Jan 28, 2023
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This seems like the best approach here. I can just be grumpy at libxml2 changing signatures though right?
Member
|
I think that we should go ahead and merge this for now. If we update the CI builders, we can remove this, it will be a bit of technical debt that we are carrying around, but it won't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml2 added
consttoxmlHashScannerin v2.9.8. Wrap the call in a version check and cast for the non-const case.