[5.7] Fix JSONDecoder superDecoder darwin/linux discrepancy #4631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't throw DecodingError if superDecoder doesn't exist * Add decoderForKeyNoThrow * Improve JSONDecoder error handling When trying to created a keyed container or unkeyed containter from a null value throw a `DecodingError.valueNotFound` error instead of a `typeMismatch` error. This is more inline with Darwin.
parkera
approved these changes
Sep 12, 2022
Contributor
|
@swift-ci test |
Contributor
Author
|
Is there any reason this hasn't been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin when you call
superDecoderon theJSONDecoderkeyed container and there is no associated value for the key passed in, it returns a new decoder that returns empty containers. On Linux it would throw aDecodingError.keyNotFounderror.This PR resolves this discrepancy by catching the
DecodingError.keyNotFounderror and returning a decoder that references aJSONValue.null.The PR also adds a new test
test_notFoundSuperDecoderto verify this fix.This resolves #3169