Skip to content

[5.7] backport some changes regarding asprintf #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2022
Merged

[5.7] backport some changes regarding asprintf #4614

merged 2 commits into from
Jul 15, 2022

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jul 13, 2022

Pull a couple of patches from main which improve handling for asprintf on Linux platforms. asprintf is vended by the system libc for most platforms (including android) when _GNU_SOURCE is defined which we do set. Backporting this ensures that we do not accidentally break the build due to re-definition of the symbol.

These should be low risk for 5.7. The changes impact only Linux and Android platforms, preventing a duplicate definition of asprintf.

soloturn and others added 2 commits July 13, 2022 08:12
@soloturn @compnerd
asprintf exists on linux
a804b38 
asprintf exists on linux for quite a while, 2015 at least. do use it.

(cherry picked from commit 865bc70)
@etcwilde @compnerd
asprintf is defined when _GNU_SOURCE is set
e9582e1 
Not all layers of the c library have asprintf defined, however, it is
available when `_GNU_SOURCE` is set.

(cherry picked from commit 96ddfc0)
@compnerd
Copy link
Member Author

compnerd commented Jul 13, 2022

CC: @parkera

@compnerd
Copy link
Member Author

compnerd commented Jul 13, 2022

@swift-ci please test

@compnerd compnerd changed the base branch from main to release/5.7 July 14, 2022 18:19
@compnerd
Copy link
Member Author

compnerd commented Jul 14, 2022

@swift-ci please test

etcwilde
etcwilde approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit a87d185 into swiftlang:release/5.7 Jul 15, 2022
@compnerd compnerd deleted the asprintf-5.7 branch July 15, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkera parkera parkera approved these changes

@etcwilde etcwilde etcwilde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@compnerd @parkera @etcwilde @soloturn