Foundation: final-ize many bridgeable interfaces
#3132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not overridden and are private fields which do not need to be emitted to the vtable. This allows these members to not impact the module serialization when `@_implementationOnly import`s are used for CoreFoundation by removing them entirely from the serialization path.
Contributor
|
@swift-ci please test and merge |
Member
Author
|
@swift-ci please test macOS platform |
Member
Author
|
Hmm, the macOS builder seems to have triggered an assertion: |
Contributor
|
Please test with following PRs: @swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not overridden and are private fields which do not need to be
emitted to the vtable. This allows these members to not impact the
module serialization when
@_implementationOnly imports are used forCoreFoundation by removing them entirely from the serialization path.