Remove unneeded check in CFRelease and CFRetain. #3104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
CFRetain
branch
2 times, most recently
from
5ba7cd6 to
51a7663
Compare
Contributor
Author
|
@etcwilde any updates? |
Member
|
This should be okay given that the definition of |
Member
|
@swift-ci please test |
Contributor
Author
|
OK I think it will work now. I just had to rebase |
AZero13
force-pushed
the
CFRetain
branch
2 times, most recently
from
086e6ab to
be48f55
Compare
Contributor
Author
|
@etcwilde can we try one more time? |
Member
|
@swift-ci please test |
Contributor
|
Please test with following PRs: @swift-ci please test macOS platform |
Contributor
|
The macOS Platform failing seems to be a bug by others which should be fixed by this PR swiftlang/swift#41115 |
If they were NULL, the program would just exit so this check is not needed
parkera
approved these changes
Sep 8, 2022
Contributor
|
@swift-ci test |
Contributor
Author
|
@parkera Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If they were NULL, the program would just exit so this check is not needed.