WASI: Make some sources unavailable in CF CMake #3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
78 tasks
Contributor
|
There are a bunch of services tied to e.g. |
Contributor
Author
|
I have a stub implementation of |
Contributor
|
@MaxDesiatov It looks like this broke the Windows build: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/130/consoleText |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFBundle, plugins, preferences, streams, and run loops are not available when compiling to WASI/Wasm because of the lack of a meaningful filesystem access and multi-threading. These sources files should be excluded from the build inCoreFoundation/CMakeLists.txtwhen compiling for that platform.