SR-14108: Implement copy() in DateFormatter.
#3008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci test |
1 similar comment
Contributor
|
@swift-ci test |
Member
Author
|
@spevans |
spevans
approved these changes
Jul 17, 2021
Contributor
spevans
left a comment
spevans
left a comment
There was a problem hiding this comment.
I ran the test under DarwinCompatibiityTests and it works fine on BigSur 1.4.4
Contributor
|
@YOCKOW Its probably worth doing a back port of this 5.5 and 5.4 since its a bug fix. |
This was referenced Jul 18, 2021
Member
Author
|
@spevans |
This was referenced Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateFormatter.copy()returns the same instance not a copied one so far.This PR adds an implementation of
copy()inDateFormatterto behave expectedly(i.e. The same behavior with DarwinFoundation).Resolves SR-14108.