Skip to content

Conversation

@compnerd
Copy link
Member

Reverts #2851

This breaks on Windows

@compnerd
Copy link
Member Author

CC: @millenomi @valeriyvan

@compnerd
Copy link
Member Author

@swift-ci please test

@millenomi
Copy link
Contributor

I merge one patch, and.

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@millenomi
Copy link
Contributor

cc @niw.

@niw
Copy link
Contributor

niw commented Aug 21, 2020

Oh no..! It should be opaque for Windows.. Let me see again.
@compnerd Thank you for catching it.

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit 4caa33a into master Aug 21, 2020
@compnerd compnerd deleted the revert-2851-wip/fix_nsdata_ignores_umask branch August 21, 2020 14:49
@niw
Copy link
Contributor

niw commented Aug 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants