build: reapir the bundling of the OLSON database on Windows #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test Linux platform |
We package the OLSON database as a binary resource in Foundation.dll. Unfortunately, something has caused a regression and OBJECT linking does not function even with CMake 3.16. Explicitly include the objects from the resource.
compnerd
force-pushed
the
the-war-of-1812
branch
from
96e0995 to
38d097f
Compare
Member
Author
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We package the OLSON database as a binary resource in Foundation.dll.
Unfortunately, something has caused a regression and OBJECT linking
does not function even with CMake 3.16. Explicitly include the
objects from the resource.