Fix warning "initialization of '...' results in a dangling pointer" #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
- When taking an UnsafePointer to an array etc, the array could be
deallocated whilst the pointer is still in use. This is fixed by
either:
1. Eliminating the pointer entirely and just passing the array or
&array to the function.
2. Creating and using the pointer inside a .withUnsafeBytes {}
or .withUnsafeMutableBytes {} closure.
spevans
force-pushed
the
pr_dangling_pointer
branch
from
f490508 to
4cf2543
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test and merge |
1 similar comment
Contributor
Author
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking an UnsafePointer to an array etc, the array could be
deallocated whilst the pointer is still in use. This is fixed by
either:
Eliminating the pointer entirely and just passing the array or
&array to the function.
Creating and using the pointer inside a .withUnsafeBytes {}
or .withUnsafeMutableBytes {} closure.