SR-7195: JSONSerialization encodes Double differently on Darwin and Linux #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inux - Use .description property of numbers to encode as String instead of using CFNumberFormatter for Float/Double, and serialising integers explictly.
Contributor
Author
|
@swift-ci please test |
Contributor
|
Looks reasonable — can we add a unit test to cover the specific values mentioned in SR-7195 so we can ensure that this at least helps with the round-tripping? |
Contributor
Author
|
@swift-ci test |
itaiferber
approved these changes
Oct 12, 2018
Contributor
Author
|
@swift-ci test and merge |
1 similar comment
Contributor
Author
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using CFNumberFormatter for Float/Double,
and serialising integers explictly.