Fixed persian calendar segmentation fault #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Porooshani <[email protected]>
Contributor
|
Looks good to me. |
Contributor
|
Do you want to try adding a simple test to verify that it works? |
Signed-off-by: Mohammad Porooshani <[email protected]>
Contributor
Author
|
@parkera Added test case in |
Contributor
|
@swift-ci test |
Signed-off-by: Mohammad Porooshani <[email protected]>
Contributor
Author
|
@spevans I'm sorry. There was an error on the test file. it is resolved now. |
Signed-off-by: Mohammad Porooshani <[email protected]>
Contributor
|
@swift-ci test |
Contributor
|
@swift-ci please test |
Contributor
Author
|
When can we expect this to be merged? |
Contributor
|
Thanks for the reminder; let's get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, initializing a calendar with
.persianidentifier results in segmentation fault error on linux.This PR aims to remedy that.