Add back unnecessarily redacted headers that now exist #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm honestly not 100% sure this is necessary, because other headers (like CFTimeZone.h for example) do |
Contributor
|
I think we need to make the same change in both CF.h headers. I agree with you that the exclusion is an artifact of before we had these files available in the open source CF. |
Contributor
Author
|
Cool, I'll update the other header, thanks! |
I think this might have been an artifact of the old CFLite redactions? Either way, these headers are now available in this repository. The real CoreFoundation guards these includes with `#ifndef CF_OPEN_SOURCE` but that doesn't seem relevant here. There are also other includes guarded by that which are not (yet? 😆) available in this repository, so I did not include them here.
copumpkin
force-pushed
the
add-back-unnecessary-redactions
branch
from
452bd6a to
1e17e6d
Compare
Contributor
Author
|
@parkera turns out the other header already had |
Contributor
|
@swift-ci test and merge |
Contributor
Author
|
Hmm, I think @swift-ci might be stuck |
Contributor
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might have been an artifact of the old CFLite redactions? Either way, these headers are now available in this repository. The real CoreFoundation guards these includes with
#ifndef CF_OPEN_SOURCEbut that doesn't seem relevant here. There are also other includes guardedby that which are not (yet? 😆) available in this repository, so I did not include them here.
cc @millenomi @parkera it's hard for me as an outsider to know the "right" thing to do around
CF_OPEN_SOURCEavoidance. I see a little bit of it still in this repo, but it's hard for me to know if that's appropriate here (in order to be more similar to the official CF) or if it's just going to be unconditionally available from now on. Any advice if I encounter more stuff like this?Edit: I'm also unclear on how I should be keeping this CoreFoundaiton.h in sync with the one in SwiftRuntime. Should I make the same change there?