Decimal and NSDecimalNumber fixes. #1653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
- NSDecimalNumber int/uint getters: Dont convert the Decimal value using the doubleValue as this can lose the lower digits for large integers which cant be accuately represented as a Double. - NSDecimalNumber.isEqual: Dont use as? to cast every value to an NSDecimalNumber but test individual types. - NSNumber.compare: If the other value is a NSDecimalNumber, upgrade self to an NSDecimalNumber to avoid loss of precison in the other value.
spevans
force-pushed
the
pr_nsdecimal_fixes
branch
from
af3c20e to
78bb21c
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSDecimalNumber int/uint getters: Dont convert the Decimal value
using the doubleValue as this can lose the lower digits for large
integers which cant be accuately represented as a Double.
NSDecimalNumber.isEqual: Dont use as? to cast every value
to an NSDecimalNumber but test individual types.
NSNumber.compare: If the other value is a NSDecimalNumber, upgrade
self to an NSDecimalNumber to avoid loss of precison in the other
value.