Skip to content

[4.2] SR-8407: NSNumber as? Bool should only work for 0 or 1 #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2018
Merged

[4.2] SR-8407: NSNumber as? Bool should only work for 0 or 1 #1651

merged 1 commit into from
Aug 3, 2018

Conversation

@spevans
Copy link
Contributor

@spevans spevans commented Aug 2, 2018

  • NSNumber as? Bool should only work for NSNumber values 0 and 1 to
    match Darwin.

@spevans
SR-8407: NSNumber as? Bool should only work for 0 or 1
6735f21 
- NSNumber as? Bool should only work for NSNumber values 0 and 1 to
  match Darwin.
@spevans
Copy link
Contributor Author

spevans commented Aug 2, 2018

@swift-ci please test

@spevans
Copy link
Contributor Author

spevans commented Aug 2, 2018

@swift-ci please test and merge

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Aug 2, 2018

@swift-ci please test and merge

@swift-ci swift-ci merged commit 2d02e61 into swiftlang:swift-4.2-branch Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkera parkera parkera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spevans @parkera @swift-ci