NSLocale.hash: Implement #1647
Merged
NSLocale.hash: Implement #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci test |
millenomi
approved these changes
Aug 3, 2018
Contributor
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSLocaleinherits hash fromNSObject, but overridesisEqual(_:)to compare contents. The default hash uses object identity, so twoNSLocaleinstances that compare equal underisEqual(_:)can produce non-equal hash values. This also breaks hashing forLocale, which calls intoNSLocale.hash.Add an implementation for
NSLocale.hashthat matchesisEqual(_:).Resolves https://bugs.swift.org/browse/SR-8448