FileManager: Fix linkItem(atPath:toPath) for directories and symlinks #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
- Recurse into any directories found in the source. - Copy any symlinks that are found. Only regular files are hard linked.
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
kperryua
reviewed
May 7, 2018
Foundation/FileManager.swift
Outdated
| } | ||
|
|
||
| open func copyItem(atPath srcPath: String, toPath dstPath: String) throws { | ||
| private func _processItem(atPath srcPath: String, toPath dstPath: String, _ body: (String, String, FileAttributeType) throws -> ()) throws { |
Contributor
There was a problem hiding this comment.
This method seems too generically named for something that creates directories. The rest looks great though.
Contributor
Author
There was a problem hiding this comment.
Is _copyOrLinkDirectoryHelper ok?
kperryua
approved these changes
May 7, 2018
Contributor
Author
|
@swift-ci please test and merge |
1 similar comment
Contributor
Author
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recurse into any directories found in the source.
Copy any symlinks that are found. Only regular files are hard linked.