[Tests] Fix exclusivity warning in TestNSData #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an exclusivity warning in TestNSData by moving assertions outside outside of a withUnsafeMutableByte() closure. This mirrors the approach taken by swiftlang#1337 to avoid the analogous warning in a similar test in this file.
Contributor
Author
|
@phausler Would you be willing to take a look? This is a similar fix to what @ianpartridge did in #1337 |
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Apr 13, 2018
Contributor
parkera
left a comment
parkera
left a comment
There was a problem hiding this comment.
I'll take this one. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an exclusivity warning in TestNSData by moving assertions outside
outside of a withUnsafeMutableByte() closure. This mirrors the approach
taken by #1337
to avoid the analogous warning in a similar test in this file.