Added URL API to Foundation.Process #1462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
approved these changes
Mar 7, 2018
CFArray._nsObject already contains String elements so bridging them to NSString crashes on Linux. Also, enabled option to retrieve “AppleLanguages” list from preferences plist in Linux.
Contributor
Author
|
I've also added a small fix to Locale static properties that produced crashes on Linux by bridging String to NSString. |
Member
|
@swift-ci please test |
1 similar comment
Contributor
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
millenomi
suggested changes
Mar 12, 2018
Contributor
millenomi
left a comment
millenomi
left a comment
There was a problem hiding this comment.
Looks like you have (problematic) NSLocale/Locale changes intermixed with this patch; can you separate?
|
|
||
| extension NSLocale { | ||
| open class var current: Locale { | ||
| open static var current: Locale { |
Contributor
There was a problem hiding this comment.
Why static? This doesn't match the Darwin signature:
class var current: Locale { get }| } | ||
|
|
||
| open class var system: Locale { | ||
| open static var system: Locale { |
Contributor
There was a problem hiding this comment.
As above for all static members. Please revert?
Contributor
Author
|
Ups, sorry, didn't think about that. I will resend two separated pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1461