Skip to content

Revert "revert string comparison changes" #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2018
Merged

Revert "revert string comparison changes" #1441

merged 1 commit into from
Feb 18, 2018

Conversation

@lancep
Copy link

@lancep lancep commented Feb 17, 2018

This reverts commit e51fb9b.

@lancep
Copy link
Author

lancep commented Feb 17, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep lancep mentioned this pull request Feb 17, 2018
Merged
@lancep
Copy link
Author

lancep commented Feb 17, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

7 similar comments
@lancep
Copy link
Author

lancep commented Feb 17, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@lancep
Copy link
Author

lancep commented Feb 18, 2018

Please test with following pull request:
swiftlang/swift#14694

@swift-ci please test

@milseman
Copy link
Member

milseman commented Feb 18, 2018

@lancep is this the one that needs to merge to fix testing on Linux? If so, ask @shahmishal or someone with merge access

@lancep
Copy link
Author

lancep commented Feb 18, 2018

@swift-ci please test

@shahmishal
Copy link
Member

shahmishal commented Feb 18, 2018

Discussed offline with @lancep, we will wait until current build completes before merging the PR.

@milseman milseman mentioned this pull request Feb 18, 2018
Merged
@shahmishal shahmishal merged commit 458977b into swiftlang:master Feb 18, 2018
@shahmishal
Copy link
Member

shahmishal commented Feb 18, 2018

Merged to unblock CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lancep @milseman @shahmishal