Skip to content

Conversation

@spevans
Copy link
Contributor

@spevans spevans commented Feb 14, 2018

  • Replace NSRange.toCountableRange() with Range.init?(_:)

  • Update Test cases.

@spevans
Copy link
Contributor Author

spevans commented Feb 14, 2018

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Feb 15, 2018

@airspeedswift does this line up with the changes you've been working on here too?

@airspeedswift
Copy link
Member

Please don't make this change. I already made it originally and had to revert it, because we don't have a 5.0 branch for corelibs-foundation, so Linux testing of the 5.0 swift branch started failing.

That said, it is a good point that the toCountableRange method should be replaced by just a Range.init. But that'll break stuff too so please hold off for now. 5.0 branch will rebranch soon, then we can do it.

Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNM for now until the range changes are on swift's 4.2 branch.

- Replace NSRange.toCountableRange() with Range.init?(_:)

- Update Test cases.
@spevans spevans force-pushed the pr_countable_range branch from d712780 to a1871e5 Compare May 3, 2018 23:41
@spevans
Copy link
Contributor Author

spevans commented May 3, 2018

@swift-ci please test

@airspeedswift
Copy link
Member

Now that the conditionally-conforming Range is available on 4.2, I think this is gtm.

@spevans
Copy link
Contributor Author

spevans commented May 4, 2018

@swift-ci please test and merge

@swift-ci swift-ci merged commit 55bb988 into swiftlang:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants