DateFormatter: disable testing of medium date style #1342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of the
DateFormattertests fail on High Sierra because the format of the.mediumdate style has changed. This is likely due to changes in the underlying platform ICU.@parkera expressed the opinion to me that we shouldn't be testing the appearance of the
DateFormatterpresets because they are subject to change and not precisely documented.I don't entirely agree with that point of view as if the format does change on Darwin platforms then we want to reflect those changes in SCLF, and having our tests start failing is the best way to detect that.
However, there is a whole separate discussion about whether Swift on Linux should use the platform ICU at all, or whether we should ship Apple's fork of ICU (which is used on Darwin) with Swift on Linux to sidestep all these problems.
As fixing the behaviour of SCLF on Linux in this regard is not practical in the short term (we don't want to diverge our CF code further from Darwin's), this PR just disables the currently failing tests. We could go further and remove/disable all the date style tests but I leave that
argumentdiscussion for another day.