Skip to content

Conversation

@ianpartridge
Copy link
Contributor

Currently, some of the DateFormatter tests fail on High Sierra because the format of the .medium date style has changed. This is likely due to changes in the underlying platform ICU.

@parkera expressed the opinion to me that we shouldn't be testing the appearance of the DateFormatter presets because they are subject to change and not precisely documented.

I don't entirely agree with that point of view as if the format does change on Darwin platforms then we want to reflect those changes in SCLF, and having our tests start failing is the best way to detect that.

However, there is a whole separate discussion about whether Swift on Linux should use the platform ICU at all, or whether we should ship Apple's fork of ICU (which is used on Darwin) with Swift on Linux to sidestep all these problems.

As fixing the behaviour of SCLF on Linux in this regard is not practical in the short term (we don't want to diverge our CF code further from Darwin's), this PR just disables the currently failing tests. We could go further and remove/disable all the date style tests but I leave that argumentdiscussion for another day.

@ianpartridge
Copy link
Contributor Author

@swift-ci please test

@alblue
Copy link
Contributor

alblue commented Nov 28, 2017

If the tests fail only on Darwin, can we have an if os that allows us to conditionally execute these changes solely for the Linux platform, but not have them cause additional noise when they run on Darwin?

@ianpartridge
Copy link
Contributor Author

I'm not sure what the purpose would be of running them on Linux. In an ideal world they would be failing there too, but they don't because of the ICU differences I mentioned.

@parkera
Copy link
Contributor

parkera commented Nov 28, 2017

Regarding noticing if they are different on different platforms: I agree that is interesting, but perhaps we should also consider that they're even different between different versions of iOS or macOS. So it's not necessarily the end of the world if they are not exactly the same.

That said - I would like consistent behavior. But, the noise caused by failing tests when attempting to get real stuff done (bigger upgrades) is costly.

@ianpartridge
Copy link
Contributor Author

Thanks @parkera - I'll merge this as a step along the road...

@swift-ci please test and merge

@swift-ci swift-ci merged commit 3d6e760 into swiftlang:master Nov 29, 2017
@ianpartridge ianpartridge deleted the disable-dateformatter-medium branch November 29, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants