Revert "[SR-6420] Ensure that the pthread_key is initialised once" #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alblue
suggested changes
Nov 28, 2017
Contributor
alblue
left a comment
alblue
left a comment
There was a problem hiding this comment.
I'm not convinced having an open GitHub issue is the right way of handling this - if we need to do further follow-ups, we should have a bug on swift.org to handle it.
Plus, we shouldn't revert this as it will re-create the memory leak caused by initializing the pthread_key multiple times.
Contributor
Author
|
Alright, file the JIRA please. |
Contributor
|
Filed SR-6491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1325
I am leaving this open temporarily, as a placeholder for figuring out the root cause of the original regression.