Remove linux/windows guard from DependencyValidationTests
#917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon and
owenv
as code owners
owenv
approved these changes
Nov 14, 2025
Collaborator
Author
|
Looks like many of these were actually not written in a way where they would be compatible with non-macOS. |
Collaborator
|
We should either fix the macOS-isms or change requireSDKs(.host) to requireSDKs(.macOS) -- right now these tests break on FreeBSD. |
These tests are actually macOS-only at this point, so the requirements should reflect that.
neonichu
force-pushed
the
bbuegling/update-dep-validation-tests
branch
from
bdf6fb0 to
137893a
Compare
Collaborator
Author
|
Updated to make these macOS only for now. |
Collaborator
Author
|
@swift-ci please test |
jakepetroules
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are actually macOS-only at this point, so the requirements should reflect that.