Further reduce lock contention around macroConfigPaths

[neonichu]

We were still going through the lock once for every MacroValueAssignment which was causing performance issues during config file parsing. This didn't really make sense since we can instead do the insert in MacroConfigFileParser and otherwise only deal in index references. Real locations only need to be materialized for code that deals with them.

rdar://164650188

[neonichu]

@swift-ci please test

[neonichu]

@swift-ci please test

[neonichu]

[2025-11-13T23:59:21.510Z] error: link command failed with exit code 1 (use -v to see invocation)
[2025-11-13T23:59:21.510Z] Undefined symbols for architecture x86_64:
[2025-11-13T23:59:21.510Z]   "SWBMacro.MacroValueAssignmentTable.push(_: SWBMacro.MacroDeclaration, _: SWBMacro.MacroExpression, conditions: SWBMacro.MacroConditionSet?, location: SWBMacro.MacroValueAssignmentLocation?) -> ()", referenced from:
[2025-11-13T23:59:21.510Z]       SWBTaskExecutionTests.(InfoPlistProcessorTaskTests in _209D8BDE03DFAB9F18A5B24C981ACA40).createMockScope(debugDescription: Swift.String, _: ((SWBMacro.MacroNamespace, inout SWBMacro.MacroValueAssignmentTable) throws -> ())?) throws -> SWBMacro.MacroEvaluationScope in InfoPlistProcessorTaskTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #4 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #7 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #7 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #10 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #10 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #13 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       closure #13 (inout SWBMacro.MacroValueAssignmentTable, SWBMacro.MacroNamespace) -> () in SWBTaskExecutionTests.(ProcessProductEntitlementsTaskActionTests in _E146C596D52A1F96CFC7E16CF2109017).performTaskAction() async throws -> () in ProcessProductEntitlementsTaskActionTests.swift.o
[2025-11-13T23:59:21.510Z]       ...
[2025-11-13T23:59:21.510Z] ld: symbol(s) not found for architecture x86_64

🤔

[neonichu]

@swift-ci please test macOS