Fixed bug with expandedSearchPaths when dealing with windows paths #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daveinglis
commented
Mar 5, 2025
daveinglis
commented
- enabled recursiveSearchPathValidation test for all hosts
- enabled some Path settings tests for all hosts
- default some testing support methods to be .host instead of .macOS
daveinglis
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
owenv
reviewed
Mar 5, 2025
jakepetroules
requested changes
Mar 5, 2025
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
jakepetroules
requested changes
Mar 6, 2025
daveinglis
force-pushed
the
pr/window_test_updates
branch
from
1c30f1b to
416a179
Compare
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Mar 7, 2025
daveinglis
force-pushed
the
pr/window_test_updates
branch
from
416a179 to
45e01e6
Compare
Contributor
Author
|
@swift-ci test |
- enabled recursiveSearchPathValidation for all hosts - enabled some Path settings tests for all hosts - default some testing support methods to be .host instead of .macOS
daveinglis
force-pushed
the
pr/window_test_updates
branch
from
45e01e6 to
fc648f0
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.