Skip to content

Conversation

@tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Jun 1, 2023

  • Explanation: Implements LSP 3.17.0's pull-model documentDiagnostics request, which fix stale squiggly issues after fixing an error due to the relationship between code in two files. When using pull-model documentDiagnostics, we disable the push-model publishDiagnostics to avoid reporting them twice.

PullDiagsDemo

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@ahoppen
Copy link
Member

ahoppen commented Jun 2, 2023

@tristanlabelle Could you also include #743 in this PR?

@tristanlabelle
Copy link
Contributor Author

My bad, here we go. @ahoppen

@ahoppen
Copy link
Member

ahoppen commented Jun 2, 2023

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Jun 2, 2023

@swift-ci Please test Windows

@tristanlabelle
Copy link
Contributor Author

Ok I see it won't be quite as simple as a cherry-pick. Looking into this

@tristanlabelle
Copy link
Contributor Author

There was a bad merge. I pushed a fix. @ahoppen , could you help me with re-running the CI?

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

1 similar comment
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@ahoppen
Copy link
Member

ahoppen commented Jun 12, 2023

@swift-ci Please test Windows

@tristanlabelle
Copy link
Contributor Author

We're good to go!

@ahoppen ahoppen merged commit af5cd53 into swiftlang:release/5.9 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants