adjust to latest SwiftPM APIs #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: support changes in SwiftPM underlying path APIs changes: * adjust call sites in SwiftPMWorkspace to use SwiftPM's path
|
tested via swiftlang/swift-package-manager#6509 |
MaxDesiatov
approved these changes
May 2, 2023
ahoppen
reviewed
May 2, 2023
Comment on lines
+31
to
+32
| import struct Basics.AbsolutePath | ||
| import struct Basics.TSCAbsolutePath |
There was a problem hiding this comment.
What’s the rule about using TSCAbsolutePath vs. AbsolutePath? Or which features will one support but not the other?
There was a problem hiding this comment.
we are slowly transitioning SwiftPM code base off of TSC. I wanted to keep the change set smaller so lets all the LSP code using the TSC version, but since some of SwiftPM public APIs are now using SwiftPM's AbsolutePath we need do some bridging in SwiftPMWorkspace. eventually all of SwiftPM public APIs will be based on swift-system Path so we will be aligned again, this is the first step to get there
ahoppen
approved these changes
May 2, 2023
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: support changes in SwiftPM underlying path APIs
changes: