Skip to content

Conversation

@MaxDesiatov
Copy link
Contributor

Non-throwing overloads are deprecated, we should use throwing ones with validating: argument label.

@MaxDesiatov MaxDesiatov self-assigned this Apr 21, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@ahoppen would you have a moment to take a look? Thanks!

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxDesiatov MaxDesiatov merged commit 7dafe17 into main May 19, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-nonthrowing-warnings branch May 19, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants