Translate the semantic token legend used by clangd to the semantic token legend used by SourceKit-LSP #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
hamishknight
approved these changes
Jun 24, 2024
bnbarham
approved these changes
Jun 25, 2024
| private let tokenTypeTranslations: [UInt32: Translation] | ||
|
|
||
| /// For all token modifiers whose representation in clang differs from the representation in SourceKit-LSP, maps the | ||
| /// index of that token type in clangd’s token type legend to the corresponding representation in SourceKit-LSP. |
There was a problem hiding this comment.
Suggested change
| /// index of that token type in clangd’s token type legend to the corresponding representation in SourceKit-LSP. | |
| /// index of that token type in clangd’s token modifier legend to the corresponding representation in SourceKit-LSP. |
…ken legend used by SourceKit-LSP clangd uses a completely different semantic token legend than SourceKit-LSP (it doesn’t even adhere to the ordering of the pre-defined token types) but we were passing index offsets from clangd through assuming that clangd uses the same legend, which was incorrect. When retrieving semantic tokens from clangd, translate the semantic tokens from clangd’s legend to SourceKit-LSP’s legend. rdar://129895062
ahoppen
force-pushed
the
translate-clangd-semantic-token-map
branch
from
cb6c995 to
80a35aa
Compare
ahoppen
changed the title
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangd uses a completely different semantic token legend than SourceKit-LSP (it doesn’t even adhere to the ordering of the pre-defined token types) but we were passing index offsets from clangd through assuming that clangd uses the same legend, which was incorrect.
When retrieving semantic tokens from clangd, translate the semantic tokens from clangd’s legend to SourceKit-LSP’s legend.
rdar://129895062