Add a request to re-index all files in SourceKit-LSP #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 24, 2024
Documentation/LSP Extensions.md
Outdated
| New request to re-index all files open in the SourceKit-LSP server. | ||
| Users should not need to rely on this request. The index should always be updated automatically in the background. Having to invoke this request manes there is a bug in SourceKit-LSP's automatic re-indexing. It does, however, offer a workaround to re-index files when such a bug occurs where otherwise there would be no workaround. |
There was a problem hiding this comment.
Suggested change
| Users should not need to rely on this request. The index should always be updated automatically in the background. Having to invoke this request manes there is a bug in SourceKit-LSP's automatic re-indexing. It does, however, offer a workaround to re-index files when such a bug occurs where otherwise there would be no workaround. | |
| Users should not need to rely on this request. The index should always be updated automatically in the background. Having to invoke this request means there is a bug in SourceKit-LSP's automatic re-indexing. It does, however, offer a workaround to re-index files when such a bug occurs where otherwise there would be no workaround. |
Sources/LanguageServerProtocol/Requests/TriggerReindexRequest.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jun 24, 2024
| await request.reply { try await pollIndex(request.params) } | ||
| case let request as RequestAndReply<BarrierRequest>: | ||
| await request.reply { VoidResponse() } | ||
| case let request as RequestAndReply<TriggerReIndexRequest>: |
There was a problem hiding this comment.
Personally I'd go with TriggerReindexRequest as ReIndex looks really odd to me. But 🤷
There was a problem hiding this comment.
I was debating whether to capitalize the I and wasn’t sure whether in a sentence re-index or reindex would be the preferred spelling. Changed it to lowercase i.
Users should not need to rely on this request. The index should always be updated automatically in the background. Having to invoke this request manes there is a bug in SourceKit-LSP's automatic re-indexing. It does, however, offer a workaround to re-index files when such a bug occurs where otherwise there would be no workaround. rdar://127476221 Resolves swiftlang#1263
|
@swift-ci Please test |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not need to rely on this request. The index should always be updated automatically in the background. Having to invoke this request manes there is a bug in SourceKit-LSP's automatic re-indexing. It does, however, offer a workaround to re-index files when such a bug occurs where otherwise there would be no workaround.
rdar://127476221
Resolves #1263