Allow prefixing of the token for a WorkDoneProgress with a custom string
#1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 19, 2024
plemarquand
reviewed
Jun 19, 2024
…tring This allows VS Code to detect when sourcekitd has crashed and prompt the user to gather a diagnostic report + file an issue about the crash. rdar://129678779 Fixes swiftlang#1476
ahoppen
force-pushed
the
work-done-progress-token-prefix
branch
from
d89f5b2 to
3003fe1
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows VS Code to detect when sourcekitd has crashed and prompt the user to gather a diagnostic report + file an issue about the crash.
I took this opportunity to refactor the WorkDoneProgress that effectively counts how many tasks of this kind are going on, into a separate type. I’m not quite happy with the name
SharedWorkDoneProgressManager. Happy for better suggestions if anyone has some.rdar://129678779
Fixes #1476