Address review comments from #1037 #1045
Merged
+478
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 1, 2024
| // MARK: - Entry point | ||
|
|
||
| extension RequestInfo { | ||
| func reduceCommandLineArguments(using executor: SourceKitRequestExecutor) async throws -> RequestInfo { |
There was a problem hiding this comment.
Occurs to me this could also be on the executor now. Up to you which you prefer.
There was a problem hiding this comment.
Let’s keep it on RequestInfo to match reduceInputFile
| // We have found a reproducer. Stop. Looking further probably won't help because other crashes are likely the same cause. | ||
| return | ||
| reproducerBundle = try await reduce(requestInfo: requestInfo, sourcekitd: sourcekitd) | ||
| // If reduce didn't thorw, we have found a reproducer. Stop. |
There was a problem hiding this comment.
Suggested change
| // If reduce didn't thorw, we have found a reproducer. Stop. | |
| // If reduce didn't throw, we have found a reproducer. Stop. |
ahoppen
force-pushed
the
ahoppen/address-reducer-review-comments
branch
from
e90f900 to
4b4942f
Compare
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/address-reducer-review-comments
branch
from
4b4942f to
1b8cb71
Compare
|
@swift-ci Please test macOS |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/address-reducer-review-comments
branch
from
1b8cb71 to
2654c83
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Hopefully this help us figure out why the diagnose tests are failing in CI.
ahoppen
force-pushed
the
ahoppen/address-reducer-review-comments
branch
from
2654c83 to
98b0b23
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially
SourceReducerby returning descriptive enums instead of optionals