Add logic to split command line arguments on Windows #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Previously, we were splitting command line arguments on Windows using the same rules as on Unix, which was incorrect, most importantly because backslashes in the first component of a Windows command line invocation are not escaping anything but interpreted verbatim. Fixes swiftlang#1020 rdar://120809063
ahoppen
force-pushed
the
ahoppen/split-windows-command-line
branch
from
b4573e9 to
cfea672
Compare
|
@swift-ci Please test |
|
@swift-ci test windows |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jan 20, 2024
Comment on lines
+116
to
+117
| assertEscapedCommand(#"" test with "" quote""#, [" test with quote"], windows: [#" test with " quote"#]) | ||
| assertEscapedCommand(#"" test with "" quote""#, [" test with quote"], windows: [#" test with " quote"#]) |
There was a problem hiding this comment.
No, Unix has with quote, Windows has with " quote (double "" results in an escaped " on Windows and an empty String on Unix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were splitting command line arguments on Windows using the same rules as on Unix, which was incorrect, most importantly because backslashes in the first component of a Windows command line invocation are not escaping anything but interpreted verbatim.
The unix command line splitting remains completely unchanged, I just moved it to a different files. Similarly, the assertions for Unix command line splitting remain the same, I just moved the test cases and restructured them slightly.
Fixes #1020
rdar://120809063