Fix CAS errors related to moving of LinkerOptions amongst other things from MCAssember to MachObjectWriter #9062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://133264719 (🌲6.0+1 CAS failures on rebranch) Because of eb22392, the LinkerOptions have been moved from MCAssembler to MachObjectWriter, but MachOCASWriter doesn't have access to those linker options, this patch fixes the bug by moving the LinkerOptions to MCObjectWriter instead.
Author
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Aug 7, 2024
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
LGTM after addressing one last comment.
rastogishubham
force-pushed
the
FixCASErrStable
branch
from
3fa9fe1 to
5c51eef
Compare
Author
|
@swift-ci please test |
|
@rastogishubham looks like this breaks the Windows build. Would you mind looking into that? (eg. https://ci-external.swift.org/job/swift-rebranch-windows-toolchain-arm64, though looks like it is currently failing for different reasons) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes any MCCAS errors we have from the work that Fangrui has done upstream to move major components from MCAssembler to MachObjectWriter